Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UEFIExtract folder names in OS X #38

Closed
gdbinit opened this issue Nov 10, 2015 · 4 comments
Closed

UEFIExtract folder names in OS X #38

gdbinit opened this issue Nov 10, 2015 · 4 comments

Comments

@gdbinit
Copy link

gdbinit commented Nov 10, 2015

Hi,

UEFIExtract will not use the GUID for firmware volumes for OS X EFI images. It instead uses "AppleCRC32 AppleFSO" text field that shows ip on UEFITool.

Instead of this code in FfsEngine::recursiveDump
QString childPath = QString("%1/%2 %3").arg(path).arg(i).arg(model->text(childIndex).isEmpty() ? model->name(childIndex) : model->text(childIndex));
it probably should be
QString childPath = QString("%1/%2 %3").arg(path).arg(i).arg(model->name(childIndex));

Personally I find it more useful to have the GUID as folder name instead of that text.

Best,
fG!

@NikolajSchlej
Copy link
Collaborator

Thanks for reporting, I will add a workaround to show GUIDs for firmware volumes even if their text fields aren't empty. Patch is ready, new binaries will be done tomorrow.

NikolajSchlej added a commit that referenced this issue Nov 10, 2015
- added a flag to use FV GUIDs as folder names even if they have
non-empty text fields. Thanks to OsxReverser for #38.
@NikolajSchlej
Copy link
Collaborator

Please excuse me for not building those binaries, I will be in Russia up to the 6th of December, will build them after returning home.
You can build a binary yourself, the required PRO file is in "UEFITool/UEFIExtract" of new_engine branch.

@gdbinit
Copy link
Author

gdbinit commented Dec 5, 2015

Ooops got lost on my mental queue. Don't worry, I got UEFITool building in OS X (pretty easy, great work!) and created something for what I wanted to do using UEFITool core code.
Keep up the great work :-)

@NikolajSchlej
Copy link
Collaborator

Will do. Closing this issue now, will release a never version today after restoring the build environment lost to a broken SSD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants