Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flatpak): fix broken desktop file, icons, and service #3561

Merged

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Jan 19, 2025

Description

Fixes desktop file for flatpak (and probably Linux in general). Flatpak icons were also excluded because they did not start with the flatpak app id. Finally, the service file requires a flatpak run ... command.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.66%. Comparing base (3048e6f) to head (77a88d7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #3561     +/-   ##
=========================================
  Coverage   11.66%   11.66%             
=========================================
  Files          93       93             
  Lines       17304    17304             
  Branches     8089     8089             
=========================================
  Hits         2018     2018             
- Misses      12806    14692   +1886     
+ Partials     2480      594   -1886     
Flag Coverage Δ
Linux 11.35% <ø> (ø)
Windows 13.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/system_tray.cpp 0.00% <ø> (ø)

... and 30 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the fix/packaing/do-not-use-svg-for-linux-desktop-file branch from 13d0c0f to 8215421 Compare January 19, 2025 16:39
@ReenigneArcher ReenigneArcher changed the title fix(packaing/linux): do not use svg for linux desktop file fix(packaing/linux): desktop file improvements Jan 19, 2025
@ReenigneArcher ReenigneArcher force-pushed the fix/packaing/do-not-use-svg-for-linux-desktop-file branch 5 times, most recently from 1cefd94 to 0a3cdb9 Compare January 20, 2025 18:19
@ReenigneArcher ReenigneArcher changed the title fix(packaing/linux): desktop file improvements fix(flatpak): fix broken desktop file and icons Jan 20, 2025
@ReenigneArcher ReenigneArcher added this to the stable release milestone Jan 20, 2025
@ReenigneArcher ReenigneArcher force-pushed the fix/packaing/do-not-use-svg-for-linux-desktop-file branch 5 times, most recently from cbbefa9 to de861ed Compare January 20, 2025 22:58
@ReenigneArcher ReenigneArcher force-pushed the fix/packaing/do-not-use-svg-for-linux-desktop-file branch from de861ed to 77a88d7 Compare January 20, 2025 23:37
@ReenigneArcher ReenigneArcher changed the title fix(flatpak): fix broken desktop file and icons fix(flatpak): fix broken desktop file, icons, and service Jan 20, 2025
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) January 20, 2025 23:49
@ReenigneArcher ReenigneArcher merged commit f5b923c into master Jan 21, 2025
37 checks passed
@ReenigneArcher ReenigneArcher deleted the fix/packaing/do-not-use-svg-for-linux-desktop-file branch January 21, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flatpak application does not run and has an invalid icon
1 participant