-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatpak application does not run and has an invalid icon #3560
Comments
This is difficult since the UI port for Sunshine can be changed. |
I put up a PR to address the svg issue. Can you test it once the build is complete? |
I get these messages in the build log as well. Seems like the tray icon won't work properly either.
|
I can definitely test it - looks like the build didn't produce an artifact with the flatpak, though? Unless there's something that I'm missing about how to get hold of that! |
@programmablereya thanks! The flatpak linter is complaining about the updated desktop file, hopefully I have satisfied that now. The build is in process again: https://github.com/LizardByte/Sunshine/actions/runs/12856505692/job/35843263796?pr=3561 |
Okay, the lint fails because "flatpak" is in the desktop file 🤷♂ https://docs.flathub.org/docs/for-app-authors/linter/#desktop-file-exec-has-flatpak-run |
I think I have a solution. I will work on it in the next few days. |
@programmablereya Okay, I think there is progress. Still an issue with the status icons though. I might need to reach out to the flatpak people on that.
Can you test it? https://github.com/LizardByte/Sunshine/actions/runs/12871812955?pr=3561 If possible can you test both the standard method, and the kms method? For reference this is the new desktop file: https://github.com/LizardByte/Sunshine/pull/3561/files#diff-8c2ac7ddc3d85265d96ca5c2e2f05a27175a062427b4b35d7ea517d68450eb64 |
Actually, this should help with the status icons. I'll get that taken care of shortly. https://docs.flatpak.org/en/latest/manifests.html#file-renaming |
New build with icons fixed. https://github.com/LizardByte/Sunshine/actions/runs/12873769335?pr=3561 I will wait until I get confirmation that this works before merging. |
(Keep reading - a problem came up while I was writing this) Beautiful! Icons work perfectly - no need to open the admin UI as long as the tray icon appears. (Presumably not having a valid icon is what was tripping it up and making the tray icon fail to appear before.) Thanks for getting this set up! ... Hmm. Perhaps I speak too soon. A minute or so after being started, it seems to crash. There's no output in the logs that suggests what exactly is going wrong; the exit code is 137, which would suggest it's being killed - but by whomst? There's no log of it being killed by OOM, and that would make little sense unless the Flatpak has a very low memory ceiling - there's still 57GB of RAM open out of 62.4GB, and Sunshine never used more than ~0.2% of it, per htop. Installing the .deb version on the same machine and running that doesn't cause this problem; it lasts just fine. Logs from the first run I did in the terminal:
The Debug version doesn't work at all (unless I'm misunderstanding its purpose):
And running again with a fresh install (with the Debug flatpak still installed) and making sure to do the additional-install first...
|
Scratch that, I think I figured out what it is - it's the gnome run-in-background killer. Apparently that remembers the choice you make and happily murders any new process started from that flatpak later. All good! |
Confirmed - turning that Run in Background toggle on did the trick, and Sunshine is now happy as between one and two clams!
|
Awesome! I will get it merged, and hopefully get a patch release out in a few days (probably going to wait to see if anything else up comes up with the latest stable). |
Just to verify... did you also test the kms version? I am not too familiar with how this works, but supposedly there is a kms entry in the desktop file. I think it requires right clicking on the main application? |
Can confirm, this worked! :) I had to use the other application launcher but I did find it!
The KMS version doesn't seem to start at all - the Run in Terminal option does start Sunshine, but it does not open a terminal. So I can't see the KMS version's debug log. Going to crack open the desktop file by hand and try to start it from a terminal to see what's going wrong. |
I guess it might not work because it needs sudo. |
Seems correct, yeah!
|
Thanks for confirming. I'll remove that part for now. |
I can file a separate bug for this, but the service doesn't work, actually:
|
No need to file a new bug. I'll get it addressed in this PR. |
For the service issue, can you try this one? https://github.com/LizardByte/Sunshine/actions/runs/12876265412?pr=3561 |
Alas, no dice:
Install logs (installed over the previous flatpak):
|
Alright, this one should solve it 🤞 https://github.com/LizardByte/Sunshine/actions/runs/12876856427/job/35900483349?pr=3561 |
Tragically not u_u Heck!!
|
I really have no idea then. This exec statement should be identical to the current flathub version (still on v0.23.1 due to a flathub build bot issue). |
I have one thing to try. |
Can you edit the service file to this and see if it works? I don't think we need to wait for the build from GitHub for this.
|
Success!! That did it! |
I was initially confused and was thinking flatpak controlled the service like they do with the desktop file. Thanks for your patience and testing everything. This fix should be merged shortly! |
Is there an existing issue for this?
Is your issue described in the documentation?
Is your issue present in the latest beta/pre-release?
This issue is present in the latest pre-release
Describe the Bug
Expected Behavior
The Sunshine application entry has the correct icon, and when clicked opens the user's default web browser to the Sunshine web UI.
Additional Context
The Icon= line in the .desktop file needs to have the .svg extension removed to be found (per desktop-file-validate; tested by removing it and verifying that it works).
Unclear what needs to be done to fix the Exec= line.
Host Operating System
Linux
Operating System Version
Pop! OS 22.04 LTS
Architecture
amd64/x86_64
Sunshine commit or version
v2025.118.151840
Package
Linux - flathub/flatpak
GPU Type
Intel
GPU Model
n/a
GPU Driver/Mesa Version
n/a
Capture Method
None
Config
Apps
n/a
Relevant log output
The text was updated successfully, but these errors were encountered: