Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(process): avoid leaking zombies and fds in detached processes #3379

Merged
merged 1 commit into from
Nov 8, 2024

fix(process): avoid leaking zombies and fds in detached processes

627b64f
Select commit
Loading
Failed to load commit list.
Merged

fix(process): avoid leaking zombies and fds in detached processes #3379

fix(process): avoid leaking zombies and fds in detached processes
627b64f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 8, 2024 in 0s

11.05% (-0.06%) compared to 54ddf37

View this Pull Request on Codecov

11.05% (-0.06%) compared to 54ddf37

Details

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 11.05%. Comparing base (54ddf37) to head (627b64f).

Files with missing lines Patch % Lines
src/platform/linux/misc.cpp 0.00% 4 Missing ⚠️
src/platform/macos/misc.mm 0.00% 4 Missing ⚠️
src/process.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3379      +/-   ##
==========================================
- Coverage   11.11%   11.05%   -0.06%     
==========================================
  Files          75       99      +24     
  Lines       13204    17237    +4033     
  Branches     6084     8036    +1952     
==========================================
+ Hits         1467     1905     +438     
- Misses       9307    12783    +3476     
- Partials     2430     2549     +119     
Files with missing lines Coverage Δ
src/process.cpp 2.68% <0.00%> (+0.53%) ⬆️
src/platform/linux/misc.cpp 9.23% <0.00%> (ø)
src/platform/macos/misc.mm 8.74% <0.00%> (-0.04%) ⬇️

... and 44 files with indirect coverage changes