fix(process): avoid leaking zombies and fds in detached processes #3379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgutman
commented
Nov 8, 2024
| @@ -241,22 +241,24 @@ namespace platf { | |||
|
|
|||
| bp::child | |||
| run_command(bool elevated, bool interactive, const std::string &cmd, boost::filesystem::path &working_dir, const bp::environment &env, FILE *file, std::error_code &ec, bp::group *group) { | |||
| // clang-format off | |||
There was a problem hiding this comment.
clang-format gets confused by the boost::process syntax and thinks bp::std_in is a template class bp::std_in<bp::null, bp::std_out>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3379 +/- ##
==========================================
- Coverage 11.11% 11.05% -0.06%
==========================================
Files 75 99 +24
Lines 13204 17237 +4033
Branches 6084 8036 +1952
==========================================
+ Hits 1467 1905 +438
- Misses 9307 12783 +3476
- Partials 2430 2549 +119
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
ReenigneArcher
approved these changes
Nov 8, 2024
qiin2333
pushed a commit
to qiin2333/Sunshine-Foundation
that referenced
this pull request
Nov 13, 2024
This was referenced Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were leaking detached child processes on Mac and Linux because we are expected to still wait on those with
waitpid()in order to reap their entry in the process table. We will now do that whenproc_t::running()is called (which happens regularly while streaming and periodically when clients poll for server info). This isn't a perfect solution but it's much better than the current situation today where all detached processes become zombies.We were also leaking file descriptors into detached processes which could cause our log files and sockets to persist longer than expected.
Screenshot
Issues Fixed or Closed
Fixes #3378
Type of Change
.github/...)Checklist