Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macos): prevent indefinite hanging if screen capture is not granted #3360

Merged

fix(macos): prevent indefinite hanging if screen capture is not granted

2b4610e
Select commit
Loading
Failed to load commit list.
Merged

fix(macos): prevent indefinite hanging if screen capture is not granted #3360

fix(macos): prevent indefinite hanging if screen capture is not granted
2b4610e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 2, 2024 in 0s

11.06% (+0.01%) compared to c54664b

View this Pull Request on Codecov

11.06% (+0.01%) compared to c54664b

Details

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 11.06%. Comparing base (c54664b) to head (2b4610e).

Files with missing lines Patch % Lines
src/platform/macos/display.mm 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3360      +/-   ##
==========================================
+ Coverage   11.05%   11.06%   +0.01%     
==========================================
  Files          99       99              
  Lines       17231    17237       +6     
  Branches     8034     8035       +1     
==========================================
+ Hits         1905     1908       +3     
- Misses      12641    12784     +143     
+ Partials     2685     2545     -140     
Files with missing lines Coverage Δ
src/platform/macos/misc.mm 8.77% <100.00%> (+1.02%) ⬆️
src/platform/macos/display.mm 40.35% <33.33%> (-0.73%) ⬇️

... and 22 files with indirect coverage changes