-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(macos): prevent indefinite hanging if screen capture is not granted #3360
fix(macos): prevent indefinite hanging if screen capture is not granted #3360
Conversation
d0148d0
to
cca03f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. The suggestions are mostly to address linting failures.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3360 +/- ##
==========================================
+ Coverage 11.05% 11.06% +0.01%
==========================================
Files 99 99
Lines 17231 17237 +6
Branches 8034 8035 +1
==========================================
+ Hits 1905 1908 +3
- Misses 12641 12784 +143
+ Partials 2685 2545 -140
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ae90cf1
to
4e22479
Compare
Currently, if Sunshine has not yet been granted the screen capture permission, the program simply hangs indefinitely on startup when it attempts to probe for usable encoders. This is not desirable because it prevents testing and using all of the parts of Sunshine that do not require the screen capture permission. With this patch, the encoder probing will simply fail instead of hanging indefinitely if Sunshine does not yet have the screen capture permission. Note that Sunshine already prints out an error message telling the user that the screen capture permission is needed. The bug is that Sunshine currently indefinitely hangs shortly after printing that message.
4e22479
to
2b4610e
Compare
Quality Gate passedIssues Measures |
Description
Currently, if Sunshine has not yet been granted the screen capture
permission, the program simply hangs indefinitely on startup when it
attempts to probe for usable encoders. This is not desirable because
it prevents testing and using all of the parts of Sunshine that do not
require the screen capture permission.
With this patch, the encoder probing will simply fail instead of
hanging indefinitely if Sunshine does not yet have the screen capture
permission.
Note that Sunshine already prints out an error message telling the user
that the screen capture permission is needed. The bug is that Sunshine
currently indefinitely hangs shortly after printing that message.
Screenshot
N/A
Issues Fixed or Closed
N/A
Type of Change
.github/...
)Checklist