Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linux): enable lowlatency mode for AMD #3088

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

ReenigneArcher
Copy link
Member

Description

Enable low latency mode for AMD by setting the appropriate environment variable. https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30039

This adds back in some helper functions to set env variables that were removed in #3059 ... although it was in the tests code before.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher marked this pull request as ready for review August 25, 2024 03:53
@ReenigneArcher ReenigneArcher force-pushed the fix/linux/enable-lowlatency-mode-for-AMD branch from 9cf6c0e to 4455cd7 Compare August 25, 2024 03:55
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 9.68%. Comparing base (ddd67ce) to head (1b7205c).
Report is 119 commits behind head on master.

Files with missing lines Patch % Lines
src/platform/linux/misc.cpp 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3088      +/-   ##
=========================================
+ Coverage    9.44%   9.68%   +0.23%     
=========================================
  Files          77     101      +24     
  Lines       14009   17933    +3924     
  Branches     6429    8375    +1946     
=========================================
+ Hits         1323    1736     +413     
- Misses      10072   13321    +3249     
- Partials     2614    2876     +262     
Flag Coverage Δ
Linux 7.20% <80.00%> (?)
Windows 5.00% <100.00%> (+0.03%) ⬆️
macOS-12 10.44% <100.00%> (+0.04%) ⬆️
macOS-13 10.35% <100.00%> (+0.04%) ⬆️
macOS-14 10.64% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/common.h 33.33% <ø> (+1.07%) ⬆️
src/platform/macos/misc.mm 8.13% <100.00%> (+1.42%) ⬆️
src/platform/windows/misc.cpp 2.62% <100.00%> (+0.44%) ⬆️
src/platform/linux/misc.cpp 9.23% <80.00%> (ø)

... and 53 files with indirect coverage changes

---- 🚨 Try these New Features:

@ReenigneArcher ReenigneArcher force-pushed the fix/linux/enable-lowlatency-mode-for-AMD branch from 4455cd7 to db3c6e1 Compare August 25, 2024 04:32
@ReenigneArcher ReenigneArcher force-pushed the fix/linux/enable-lowlatency-mode-for-AMD branch from db3c6e1 to 1b7205c Compare August 25, 2024 13:59
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants