-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tests): rework tests in numerous ways #3059
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3059 +/- ##
=========================================
- Coverage 7.25% 7.15% -0.10%
=========================================
Files 91 91
Lines 16464 16464
Branches 7785 7780 -5
=========================================
- Hits 1194 1178 -16
- Misses 12672 12687 +15
- Partials 2598 2599 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Added test run details to the log
Maybe not the best formatting, but it's fairly easy to change afterwards. |
Everything is done from my end, if anyone has some issues with particular parts of the PR I can revert them. |
86f7bb2
to
ae2c3e7
Compare
LGTM |
@FrogTheFrog here you go b20d022, one more LGTM please 🐸 |
LGTM 🐸 |
b20d022
to
0239325
Compare
Quality Gate failedFailed conditions |
Description
Architectural
BaseTest
class andTEST()
redefinition, tests don't need to derive from it from now onPlatformInitBase
that inherited fromBaseTest
with lightweightPlatformTestSuite
, platform initialization/deinitialization is done in static methodsSetUpTestSuite()/TearDownTestSuite()
and doesn't interfere with fixture initializationmain()
entry point fromgtest_main
Logging
BOOST_LOG
test_sunshine.log
can be uploaded as github actions artifact in CItests
hidden behindSUNSHINE_TESTS
compile definitionSUNSHINE_TESTS
cout
messages toBOOST_LOG(tests)
Cosmetics
::testing
namespace withtesting
, safeguarding against conflicts is pointless when we should not introduce them in the first placeclass
withstruct
and dropped all access specifiers, here such access specifiers only add noise0,1,2...
to custom names where it was applicableScreenshot
Issues Fixed or Closed
Type of Change
.github/...
)Checklist