Disable HDR encoding for AMF versions below 1.4.23 #1521
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some older AMD AMF DLLs seem to crash when attempting to perform HEVC Main10 encoder tests, even if the underlying hardware doesn't support HEVC Main10 encoding at all. Since we probe all encoders on startup, this cause a crash loop.
To avoid this crash, we will specifically check for an AMD AMF version >= 1.4.23 before allowing HDR encoding. This AMF version corresponds to driver version 21.12.1 (almost 2 years old) and is a supported driver for all AMD cards with HEVC Main10 support.
Note: There are drivers from the legacy support branch that have versions newer than 21.12.1 but these all include older AMF versions (1.4.20 for the latest legacy driver version 22.6.1), so this check works as expected to exclude those drivers.
Pre-merge checklist:
Screenshot
Issues Fixed or Closed
Fixes #1503
Resolves #1012
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.