Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable HDR encoding for AMF versions below 1.4.23 #1521

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

cgutman
Copy link
Collaborator

@cgutman cgutman commented Aug 10, 2023

Description

Some older AMD AMF DLLs seem to crash when attempting to perform HEVC Main10 encoder tests, even if the underlying hardware doesn't support HEVC Main10 encoding at all. Since we probe all encoders on startup, this cause a crash loop.

To avoid this crash, we will specifically check for an AMD AMF version >= 1.4.23 before allowing HDR encoding. This AMF version corresponds to driver version 21.12.1 (almost 2 years old) and is a supported driver for all AMD cards with HEVC Main10 support.

Note: There are drivers from the legacy support branch that have versions newer than 21.12.1 but these all include older AMF versions (1.4.20 for the latest legacy driver version 22.6.1), so this check works as expected to exclude those drivers.

Pre-merge checklist:

  • Verify that it resolves crashes for Vega users

Screenshot

Issues Fixed or Closed

Fixes #1503
Resolves #1012

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@cgutman cgutman force-pushed the block_hdr_on_old_amf branch from 0a02246 to 22f4504 Compare August 11, 2023 04:39
@cgutman cgutman force-pushed the block_hdr_on_old_amf branch from 22f4504 to aa45eba Compare August 11, 2023 22:42
@cgutman cgutman merged commit 4186d83 into LizardByte:nightly Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant