Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coherence time axis #501

Merged
merged 5 commits into from
Jan 8, 2024
Merged

Coherence time axis #501

merged 5 commits into from
Jan 8, 2024

Conversation

CommonClimate
Copy link
Collaborator

Problem : the original code was creating tau based on the left series, not the right. This is now fixed, using the "common_time" rule. Additionally, the dashboard restricts the view to the period of overlap. Here's a MWE:

import pyleoclim as pyleo
SOI = pyleo.utils.load_dataset('SOI')
NINO3 = pyleo.utils.load_dataset('NINO3')
coh_wwz = NINO3.wavelet_coherence(SOI, method='wwz')
fig, ax = coh_wwz.dashboard()

The result should look like this:
coherence_overlap

this should address #479 . TODO: update tutorials

@khider khider merged commit 4e2b4fd into master Jan 8, 2024
1 check passed
@CommonClimate CommonClimate deleted the coh_time_axis branch January 18, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants