Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using wwz for coherence the timeseries are not placed on the common axis properly #479

Closed
khider opened this issue Nov 28, 2023 · 4 comments
Assignees
Labels

Comments

@khider
Copy link
Member

khider commented Nov 28, 2023

When using wwz at the method for coherence, the timeseries are not truncated properly. According to the doc, it should use the default for common_time, which should lead to using the max of the min time and the min of the max time. When trying to specifically pass a start and end time, common_time is ignored.

coherence_dashbaord

@CommonClimate
Copy link
Collaborator

Can you provide more details on this? What are you passing, and what result are you getting? A MWE to reproduce the bug would be great.

@khider
Copy link
Member Author

khider commented Jan 5, 2024

Can't share the actual data. But I passed the two timeseries using all default option first but with method='wwz'.

Then I tried:

ts1.wavelet_coherence(ts2, method='wwz', common_time_kwargs = {'start': 800, 'stop':2002})

It doesn't truncate. I had to slice first then use the method on the sliced timeseries.

@CommonClimate
Copy link
Collaborator

OK, I'll try on a mockup example

@CommonClimate
Copy link
Collaborator

addressed by #501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

3 participants