Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BERTScore default values + peculiar module behaviour #760

Merged
merged 3 commits into from
Jan 16, 2022
Merged

Fix BERTScore default values + peculiar module behaviour #760

merged 3 commits into from
Jan 16, 2022

Conversation

stancld
Copy link
Contributor

@stancld stancld commented Jan 15, 2022 •
edited
Loading

What does this PR do?

Related to issues with BERTScore in #759

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jan 15, 2022 •
edited
Loading

Codecov Report

Merging #760 (b84a110) into master (b9537be) will decrease coverage by 0%.
The diff coverage is 96%.

@@          Coverage Diff          @@
##           master   #760   +/-   ##
=====================================
- Coverage      95%    95%   -0%     
=====================================
  Files         171    171           
  Lines        6888   6898   +10     
=====================================
+ Hits         6519   6528    +9     
- Misses        369    370    +1

@stancld stancld marked this pull request as ready for review January 15, 2022 11:57
@Borda Borda added the bug / fix Something isn't working label Jan 15, 2022
@Borda Borda added this to the v0.7 milestone Jan 15, 2022
@mergify mergify bot added the ready label Jan 15, 2022
@Borda Borda enabled auto-merge (squash) January 16, 2022 19:55
rohitgr7
rohitgr7 approved these changes Jan 16, 2022
View reviewed changes
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

torchmetrics/text/bert.py Outdated Show resolved Hide resolved
@Borda Borda merged commit b1d0a7a into master Jan 16, 2022
@Borda Borda deleted the fix/bertscore branch January 16, 2022 21:07
@stancld stancld mentioned this pull request Jan 16, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@ethanwharris ethanwharris Awaiting requested review from ethanwharris

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@SkafteNicki SkafteNicki Awaiting requested review from SkafteNicki SkafteNicki is a code owner

@tchaton tchaton Awaiting requested review from tchaton

Assignees
No one assigned
Labels
bug / fix Something isn't working ready
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@stancld @Borda @rohitgr7