-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conditional skip Doctests #759
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@stancld seems the docs example does not work as BERT requires models name... ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try to add model_name_or_path="roberta-base"
manually if it works :]
so it means that default none is not valid input... |
Co-authored-by: Daniel Stancl <[email protected]>
Unfortunately, it looks like so.. I'll send a quick fix tomorrow morning. It should be only about some input validation. |
Co-authored-by: Daniel Stancl <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #759 +/- ##
=====================================
Coverage 95% 95%
=====================================
Files 171 171
Lines 6898 6913 +15
=====================================
+ Hits 6528 6555 +27
+ Misses 370 358 -12 |
Co-authored-by: Daniel Stancl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ LGTM!
the HF cache seems strange as I still see time to time following download error:
(mostly on MacOS) |
What does this PR do?
Fixes #733
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃