Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify CI horovod #4951

Merged
merged 2 commits into from
Dec 7, 2020
Merged

simplify CI horovod #4951

merged 2 commits into from
Dec 7, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Dec 2, 2020

What does this PR do?

after #4941 we shall have a path to the root so the local setting shall not be needed...

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the ci Continuous Integration label Dec 2, 2020
@Borda Borda added this to the 1.1.x milestone Dec 2, 2020
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #4951 (b5de45d) into master (b00991e) will increase coverage by 3%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #4951    +/-   ##
=======================================
+ Coverage      90%     93%    +3%     
=======================================
  Files         129     129            
  Lines        9372    9372            
=======================================
+ Hits         8423    8689   +266     
+ Misses        949     683   -266     

@tchaton
Copy link
Contributor

tchaton commented Dec 3, 2020

@Borda It seems to broke some tests.

@Borda
Copy link
Member Author

Borda commented Dec 3, 2020

@Borda It seems to broke some tests.

true but it strange that it works on GPU fine :]

@Borda Borda added 3rd party Related to a 3rd-party help wanted Open to be worked on labels Dec 3, 2020
@Borda Borda added ready PRs ready to be merged and removed help wanted Open to be worked on ready PRs ready to be merged labels Dec 6, 2020
@Borda Borda changed the title simplify CI horovod simplify CI horovod [wip] Dec 6, 2020
@Borda
Copy link
Member Author

Borda commented Dec 7, 2020

ok, I found the problem, Conda env do not use PYTHONPATH so the PL path is missing...
this basically means that all our tests with DDP will/may fail if they run on Conda... @tchaton

@Borda Borda changed the title simplify CI horovod [wip] simplify CI horovod Dec 7, 2020
@Borda Borda merged commit ab7c947 into master Dec 7, 2020
@Borda Borda deleted the ci/horovod branch December 7, 2020 09:31
@Borda Borda modified the milestones: 1.1.x, 1.1 Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Related to a 3rd-party ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants