-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI cleaning #4941
CI cleaning #4941
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4941 +/- ##
======================================
Coverage 93% 93%
======================================
Files 124 124
Lines 9320 9320
======================================
Hits 8640 8640
Misses 680 680 |
TEMP_PATH = os.path.join(PROJECT_ROOT, 'test_temp') | ||
|
||
if PROJECT_ROOT not in os.getenv('PYTHONPATH', ""): | ||
os.environ['PYTHONPATH'] = f'{PROJECT_ROOT}:{os.environ.get("PYTHONPATH", "")}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
his we can probably drop the relative path to root for Horovod... :]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work there !
What does this PR do?
Fixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃