Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to Parameters to MixedPrecisionPlugin are not validated and do not match doc string #17687

Merged
merged 16 commits into from
Jun 7, 2023
Merged

Fix to Parameters to MixedPrecisionPlugin are not validated and do not match doc string #17687

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
399ad14
Validate amp plugin parameters and update doc string
May 23, 2023
c8439e9
Address comments
May 24, 2023
1fc31b0
Updated changelogs
May 24, 2023
a8806c5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 24, 2023
bb7ae8c
Update tests/tests_fabric/plugins/precision/test_amp.py
awaelchli May 29, 2023
1b10e30
Merge branch 'master' into amp-plugin-config-validate
Borda May 29, 2023
5730dc1
Updated exception message as suggested
May 30, 2023
0166e1f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 30, 2023
37e3bf9
remove unsupported options
awaelchli Jun 6, 2023
bafc64c
add missing period
awaelchli Jun 6, 2023
3e20ef9
remove unused fixture
awaelchli Jun 6, 2023
017d8f0
Merge branch 'master' into amp-plugin-config-validate
awaelchli Jun 6, 2023
48e2510
fix line too long
awaelchli Jun 6, 2023
53af163
remove unsupported options
awaelchli Jun 6, 2023
758f1db
Update src/lightning/pytorch/plugins/precision/amp.py
carmocca Jun 6, 2023
d24dbd3
Merge branch 'master' into amp-plugin-config-validate
carmocca Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update tests/tests_fabric/plugins/precision/test_amp.py
  • Loading branch information
@awaelchli
awaelchli authored May 29, 2023
commit bb7ae8c0092166a363863d7622d2a8018e661602
2 changes: 1 addition & 1 deletion tests/tests_fabric/plugins/precision/test_amp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def test_amp_precision_optimizer_step_without_scaler():
optimizer.step.assert_called_once_with(keyword="arg")


def test_amp_precisionparameter_validation():
def test_amp_precision_parameter_validation():
MixedPrecision("16-mixed", "cpu") # should not raise exception
MixedPrecision("bf16-mixed", "cpu")

Expand Down