-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to Parameters to MixedPrecisionPlugin
are not validated and do not match doc string
#17687
Fix to Parameters to MixedPrecisionPlugin
are not validated and do not match doc string
#17687
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad that you found time!
We should also update:
- https://github.com/Lightning-AI/lightning/blob/master/src/lightning/fabric/plugins/precision/amp.py
- Fabric's CHANGELOG.md
- Trainer's CHANGELOG.md
- Improved Exception Message - Added match to pytest exception check - Added parameter validation to fabric
Address the comments, added parameter validation to fabric (docstring is already correct there), added a line to each CHANGELOG. |
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #17687 +/- ##
=========================================
- Coverage 84% 60% -24%
=========================================
Files 419 414 -5
Lines 31721 31583 -138
=========================================
- Hits 26634 18810 -7824
- Misses 5087 12773 +7686 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failures look real:
FAILED strategies/test_fsdp.py::test_precision_plugin_config[16-true-expected2] - ValueError: `FSDPMixedPrecisionPlugin(precision='16-true')` must be '16-mix...
FAILED strategies/test_fsdp.py::test_precision_plugin_config[bf16-true-expected3] - ValueError: `FSDPMixedPrecisionPlugin(precision='bf16-true')` must be '16-m...
…not match doc string (#17687) Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]> (cherry picked from commit f111bd4)
…not match doc string (#17687) Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]> (cherry picked from commit f111bd4)
What does this PR do?
Fixes #17288
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist