Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a bug that causes CSVLogger to overwrite version_0 when root_dir is a relative path. #17139

Merged
merged 17 commits into from
May 6, 2023
Merged

Fixes a bug that causes CSVLogger to overwrite version_0 when root_dir is a relative path. #17139

merged 17 commits into from
May 6, 2023

Conversation

water-vapor
Copy link
Contributor

@water-vapor water-vapor commented Mar 19, 2023 •
edited
Loading

What does this PR do?

Fixes a bug that causes CSVLogger to overwrite version_0 when root_dir is a relative path.

Fixes #17138

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Mar 19, 2023
@water-vapor water-vapor mentioned this pull request Mar 19, 2023
Closed
@codecov
Copy link

codecov bot commented Mar 19, 2023 •
edited
Loading

Codecov Report

Merging #17139 (4784852) into master (4413e98) will decrease coverage by 23%.
The diff coverage is 100%.

❗ Current head 4784852 differs from pull request most recent head ceee702. Consider uploading reports for the commit ceee702 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##           master   #17139     +/-   ##
=========================================
- Coverage      84%      61%    -23%     
=========================================
  Files         419      409     -10     
  Lines       31561    31377    -184     
=========================================
- Hits        26594    19227   -7367     
- Misses       4967    12150   +7183

@mergify mergify bot removed the has conflicts label Mar 20, 2023
@awaelchli awaelchli added logger: csv bug Something isn't working labels Mar 21, 2023
awaelchli
awaelchli reviewed Mar 21, 2023
View reviewed changes
tests/tests_fabric/loggers/test_csv.py Outdated Show resolved Hide resolved
tests/tests_fabric/loggers/test_csv.py Outdated Show resolved Hide resolved
tests/tests_fabric/loggers/test_csv.py Outdated Show resolved Hide resolved
@awaelchli awaelchli added this to the v1.9.x milestone Mar 21, 2023
@awaelchli
Copy link
Contributor

This was probably introduced here: #16880
So I'm setting the milestone to 2.0.x for cherry-picking.

@awaelchli awaelchli modified the milestones: v1.9.x, 2.0.x Mar 21, 2023
@carmocca carmocca added the community This PR is from the community label Mar 21, 2023
@Borda Borda requested a review from awaelchli April 27, 2023 11:28
lantiga
lantiga approved these changes May 5, 2023
View reviewed changes
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added the ready PRs ready to be merged label May 5, 2023
@Borda Borda enabled auto-merge (squash) May 5, 2023 10:04
@awaelchli awaelchli disabled auto-merge May 5, 2023 23:45
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label May 5, 2023
@awaelchli awaelchli enabled auto-merge (squash) May 5, 2023 23:45
@awaelchli awaelchli merged commit a36af3f into Lightning-AI:master May 6, 2023
Borda pushed a commit that referenced this pull request Jun 1, 2023
@water-vapor @Borda
Fixes a bug that causes CSVLogger to overwrite version_0 when `ro…
09b4c51 
…ot_dir` is a relative path. (#17139)

Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>

(cherry picked from commit a36af3f)
Borda pushed a commit that referenced this pull request Jun 1, 2023
@water-vapor @Borda
Fixes a bug that causes CSVLogger to overwrite version_0 when `ro…
7219482 
…ot_dir` is a relative path. (#17139)

Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>

(cherry picked from commit a36af3f)
lantiga pushed a commit that referenced this pull request Jun 2, 2023
@water-vapor @lantiga
Fixes a bug that causes CSVLogger to overwrite version_0 when `ro…
4bbaa17 
…ot_dir` is a relative path. (#17139)

Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>

(cherry picked from commit a36af3f)
@awaelchli awaelchli mentioned this pull request Jun 25, 2023
Closed
@awaelchli awaelchli mentioned this pull request Jul 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantiga lantiga lantiga approved these changes

@Borda Borda Borda approved these changes

@justusschock justusschock justusschock approved these changes

@carmocca carmocca Awaiting requested review from carmocca

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@awaelchli awaelchli Awaiting requested review from awaelchli

Assignees
No one assigned
Labels
bug Something isn't working community This PR is from the community fabric lightning.fabric.Fabric logger: csv pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Milestone
2.0.x
Development

Successfully merging this pull request may close these issues.

CSVLogger overwriting previous logs when giving relative root dir
6 participants
@water-vapor @awaelchli @lantiga @Borda @justusschock @carmocca