Fixes a bug that causes CSVLogger to overwrite version_0 when `ro…

…ot_dir` is a relative path. (#17139)

Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>

(cherry picked from commit a36af3f)

src/lightning/fabric/CHANGELOG.md

@@ -14,7 +14,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 
 ### Fixed
 
--
+- Fixed computing the next version folder in `CSVLogger` ([#17139](https://github.com/Lightning-AI/lightning/pull/17139))
+
+
 
 
 ## [2.0.2] - 2023-04-24

src/lightning/fabric/loggers/csv_logs.py

@@ -156,9 +156,10 @@ def _get_next_version(self) -> int:
             return 0
 
         existing_versions = []
-        for d in self._fs.listdir(root_dir, detail=False):
-            name = d[len(root_dir) + 1 :]  # removes parent directories
-            if self._fs.isdir(d) and name.startswith("version_"):
+        for d in self._fs.listdir(root_dir):
+            full_path = d["name"]
+            name = os.path.basename(full_path)
+            if self._fs.isdir(full_path) and name.startswith("version_"):
                 existing_versions.append(int(name.split("_")[1]))
 
         if len(existing_versions) == 0:

src/lightning/pytorch/CHANGELOG.md

@@ -23,6 +23,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 - The `WandbLogger` no longer flattens dictionaries in the hyperparameters logged to the dashboard ([#17574](https://github.com/Lightning-AI/lightning/pull/17574))
 
 
+- Fixed computing the next version folder in `CSVLogger` ([#17139](https://github.com/Lightning-AI/lightning/pull/17139))
+
 
 ## [2.0.2] - 2023-04-24
 

tests/tests_fabric/loggers/test_csv.py

@@ -30,6 +30,17 @@ def test_file_logger_automatic_versioning(tmpdir):
     assert logger.version == 2
 
 
+def test_file_logger_automatic_versioning_relative_root_dir(tmpdir, monkeypatch):
+    """Verify that automatic versioning works, when root_dir is given a relative path."""
+    root_dir = tmpdir.mkdir("exp")
+    logs_dir = root_dir.mkdir("logs")
+    logs_dir.mkdir("version_0")
+    logs_dir.mkdir("version_1")
+    monkeypatch.chdir(tmpdir)
+    logger = CSVLogger(root_dir="exp/logs", name="logs")
+    assert logger.version == 2
+
+
 def test_file_logger_manual_versioning(tmpdir):
     """Verify that manual versioning works."""
     root_dir = tmpdir.mkdir("exp")