Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename profiler/ directory to profilers/ #11972 #12046

Conversation

Pragyanstha
Copy link

@Pragyanstha Pragyanstha commented Feb 22, 2022

What does this PR do?

Fixes #11972

  1. A copy of profiler/ directory was created with directory name profilers/.
  2. Relevant import statements (including the docs and examples) were modified accordingly.
  3. The original profiler API was modified so that it redirects to the newer one and gives a deprecated warning as suggested in
    Rename profiler/ directory to profilers/ #11972 (comment).

Does your PR introduce any breaking changes? If yes, please list them.

tests are failing due to renamed files and folders

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Yup.

@rohitgr7
Copy link
Contributor

maybe we could do this in 2 separate PRs to keep the git history:

  1. rename profiler to profilers and update references.
  2. add profiler directory back which basically redirects the call to profilers with a deprecation message.

@stale
Copy link

stale bot commented Mar 10, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Mar 10, 2022
@Pragyanstha Pragyanstha reopened this Mar 12, 2022
@stale stale bot removed the won't fix This will not be worked on label Mar 12, 2022
@Pragyanstha
Copy link
Author

Pragyanstha commented Mar 12, 2022

Closing this one to make 2 seperate PRs as suggested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename profiler/ directory to profilers/
2 participants