Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename profiler/ directory to profilers/ #11972

Closed
daniellepintz opened this issue Feb 18, 2022 · 6 comments · Fixed by #12308
Closed

Rename profiler/ directory to profilers/ #11972

daniellepintz opened this issue Feb 18, 2022 · 6 comments · Fixed by #12308
Assignees
Labels
good first issue Good for newcomers help wanted Open to be worked on profiler refactor

Comments

@daniellepintz
Copy link
Contributor

daniellepintz commented Feb 18, 2022

Proposed refactor

Rename profiler/ directory to profilers/

Motivation

The other directory names are plural, like callbacks/, strategies/, accelerators/- let's do the same for profilers. Part of #11908

cc @Borda @justusschock @awaelchli @rohitgr7 @carmocca @kaushikb11 @ninginthecloud

@ananthsub ananthsub added the good first issue Good for newcomers label Feb 18, 2022
@Pragyanstha
Copy link

Hi ! I would love to work on this issue if it is available

@daniellepintz
Copy link
Contributor Author

Awesome, thanks! Assigned you the issue

@Pragyanstha
Copy link

@daniellepintz
I have a question.
From what I understand, since this change would be backward incompatible, what is the recommended way to give deprecated warning for pytorch_lightning.profiler API ?

@akihironitta
Copy link
Contributor

Hi @Pragyanstha, it'll look almost the same as pytorch_lightning.plugins.training_type.* (which reroutes to pytorch_lightning.strategies.*).

https://github.com/PyTorchLightning/pytorch-lightning/blob/6bc0e1da6329c42ec3b7c6fbf91eb059b9124207/pytorch_lightning/plugins/training_type/ddp.py#L18-L23

@Pragyanstha
Copy link

@akihironitta
Ah I see, so we keep the profiler directory and do the same. Thanks !

@bonysureliya
Copy link

Hello i would love to work on the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Open to be worked on profiler refactor
Projects
None yet
5 participants