Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable flaky tests #1629

Merged
merged 4 commits into from
Jan 10, 2025
Merged

disable flaky tests #1629

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
342b011
disable flaky test and reenable some others
t-vi Jan 10, 2025
da14771
reenable more tests
t-vi Jan 10, 2025
a60dfb5
more disabling
t-vi Jan 10, 2025
dd1b22c
fix link thank you
t-vi Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions thunder/tests/test_dynamo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,10 +445,6 @@ def func(x):
IS_WINDOWS,
reason="torch.compile Windows support is still WIP - https://github.com/pytorch/pytorch/issues/122094",
),
pytest.mark.skipif(
version_between(torch.__version__, min_ver="2.6.0dev0", max_ver="2.6.0a99"),
reason="https://github.com/Lightning-AI/lightning-thunder/issues/1471",
),
),
)
@requiresCUDA
Expand Down
26 changes: 12 additions & 14 deletions thunder/tests/test_networks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,16 @@ def test_nanogpt_complete_cudagraphs(executor, device, dtype):
assert _there_is_cudagraph_sym(thunder.last_traces(tom)[-1])


@instantiate(dtypes=(thunder.float32,), devicetypes=(thunder.devices.DeviceType.CUDA,))
@requiresCUDA
@instantiate(
dtypes=(thunder.float32,),
devicetypes=(thunder.devices.DeviceType.CUDA,),
decorators=(
pytest.mark.skipif(
version_between(torch.__version__, min_ver="2.7.0dev0", max_ver="2.7.0a99"),
reason="https://github.com/bitsandbytes-foundation/bitsandbytes/pull/1629",
t-vi marked this conversation as resolved.
Show resolved Hide resolved
),
),
)
def test_nanogpt_complete_cudagraphs_autograd(executor, device, dtype):
tdtype = ttorch.to_torch_dtype(dtype)

Expand Down Expand Up @@ -224,12 +232,6 @@ def test_nanogpt_mlp(executor, device, dtype):
@instantiate(
dtypes=(thunder.float32,),
executors=all_test_executors_and_dynamo,
decorators=(
pytest.mark.skipif(
version_between(torch.__version__, min_ver="2.6.0dev0", max_ver="2.6.0a99"),
reason="https://github.com/Lightning-AI/lightning-thunder/issues/1471",
),
),
)
def test_nanogpt_gelu(executor, device, dtype):
tdtype = ttorch.to_torch_dtype(dtype)
Expand Down Expand Up @@ -366,8 +368,8 @@ def test_quantization():


@pytest.mark.skipif(
version_between(torch.__version__, min_ver="2.6.0dev0", max_ver="2.6.0a99"),
reason="https://github.com/Lightning-AI/lightning-thunder/issues/1471",
version_between(torch.__version__, min_ver="2.7.0dev0", max_ver="2.7.0a99"),
reason="https://github.com/bitsandbytes-foundation/bitsandbytes/pull/1629",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I'm late to the party here.

This link leads me to a 404. BitsAndBytes pull request #'s / issue #'s are at around 1475 now, so ~150 below the 1629 mentioned here. Is this a private PR maybe? Or did you mean to copy/paste this PR (#1629) and B&B somehow got pulled in?

)
@thunder.tests.framework.requiresCUDA
def test_thunderfx_mistral_nemo_small():
Expand Down Expand Up @@ -420,10 +422,6 @@ def test_thunderfx_mistral_nemo_small():


# disabled "Qwen/Qwen2.5-7B-Instruct" see https://github.com/NVIDIA/Fuser/issues/3682
@pytest.mark.skipif(
version_between(torch.__version__, min_ver="2.6.0dev0", max_ver="2.6.0a99"),
reason="https://github.com/Lightning-AI/lightning-thunder/issues/1471",
)
@thunder.tests.framework.requiresCUDA
@pytest.mark.parametrize("model_id", ["microsoft/Phi-3-mini-128k-instruct"])
def test_hf_for_nemo(model_id):
Expand Down
4 changes: 0 additions & 4 deletions thunder/tests/test_recipes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,6 @@ def test_recipe_basic_bert():
assert_close(actual, expected)


@pytest.mark.skipif(
version_between(torch.__version__, min_ver="2.6.0dev0", max_ver="2.6.0a99"),
reason="https://github.com/Lightning-AI/lightning-thunder/issues/1471",
)
def test_recipe_basic_bert_dynamo():
bert = transformers.BertForSequenceClassification(transformers.BertConfig())
del bert.bert.encoder.layer[1:]
Expand Down
Loading