disable flaky tests #1629
Merged
disable flaky tests #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lantiga
approved these changes
Jan 10, 2025
tfogal
reviewed
Jan 11, 2025
| version_between(torch.__version__, min_ver="2.6.0dev0", max_ver="2.6.0a99"), | ||
| reason="https://github.com/Lightning-AI/lightning-thunder/issues/1471", | ||
| version_between(torch.__version__, min_ver="2.7.0dev0", max_ver="2.7.0a99"), | ||
| reason="https://github.com/bitsandbytes-foundation/bitsandbytes/pull/1629", |
There was a problem hiding this comment.
Sorry I'm late to the party here.
This link leads me to a 404. BitsAndBytes pull request #'s / issue #'s are at around 1475 now, so ~150 below the 1629 mentioned here. Is this a private PR maybe? Or did you mean to copy/paste this PR (#1629) and B&B somehow got pulled in?
riccardofelluga
pushed a commit
that referenced
this pull request
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...reenable some others
fixes #1471