Fix #3366: Wrap plain-text error responses from the API in JSON

[PawanHegde]

Summary

• All LemmyErrors should be returned as JSON.
  • The previous behaviour was that if there was no explicit message, the message of the inner error was returned as text/plain.
• Add a default handler for all 400-599 HTTP status responses that are not LemmyErrors.
  • This covers exceptions thrown by actix itself. The default handler for the framework returns text/plain messages.
• 🆕 ErrorType is compulsory for creating LemmyError and "Unknown" errors need to at least have a message.
• 🆕 The format of error response is consistent with the new LemmyErrorType changes in Error enum fixed #3487
• 🆕 Fixed Clippy errors

Testing done

• Valid call.

~ ❯ curl "http://localhost:8536/api/v3/comment/list?post_id=1&sort=New&type_=Local" -i                                                                                                                                                            
HTTP/1.1 200 OK
content-length: 15
access-control-expose-headers: content-type
vary: Origin, Access-Control-Request-Method, Access-Control-Request-Headers
content-type: application/json
date: Mon, 10 Jul 2023 18:17:51 GMT

{"comments":[]}

• Bad parameter. Error thrown by actix.

~ ❯ curl "http://localhost:8536/api/v3/comment/list?post_id=1&sort=New&type_=Test" -i                                                                                                                                                             
HTTP/1.1 400 Bad Request
content-length: 125
content-type: application/json
date: Mon, 10 Jul 2023 18:17:57 GMT

{"error":"unknown","message":"Query deserialize error: unknown variant `Test`, expected one of `All`, `Local`, `Subscribed`"}                                                                                                               ~ ❯                                                                                                                                                                                                                                              

• Brought down database. Error thrown by Lemmy.

~ ❯ curl "http://localhost:8536/api/v3/comment/list?post_id=1&sort=New&type_=Local" -i                                                                                                                                                            
HTTP/1.1 400 Bad Request
content-length: 136
content-type: application/json
vary: Origin, Access-Control-Request-Method, Access-Control-Request-Headers
access-control-expose-headers: content-type
date: Mon, 10 Jul 2023 18:18:35 GMT

{"error":"unknown","message":"Error occurred while creating a new object: error connecting to server: Connection refused (os error 61)"}      

[Nutomic]

Looks good, thanks! However clippy is failing, most likely because of using unwrap. You can run ./scripts/fix-clippy.sh to check and replace them with expect or similar.

[dessalines]

Seems like a little bit of bloat to add the whole middleware, but I spose its fine.

[PawanHegde]

Thanks for the reviews. I've had to update some code because of the changes in #3487. I've updated the summary as well.