Only update site_aggregates for local site #3516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Or maybe it's supposed to calculate it for all sites, and the bug is actually the fact that all sites are getting post and comment counts of the local site? I will check the code a bit more |
Nutomic
approved these changes
Jul 10, 2023
dessalines
approved these changes
Jul 10, 2023
|
Good catch, thanks. |
dessalines
pushed a commit
that referenced
this pull request
Jul 10, 2023
PawanHegde
pushed a commit
to PawanHegde/lemmy
that referenced
this pull request
Jul 10, 2023
Nutomic
added a commit
that referenced
this pull request
Jul 10, 2023
* Fix #3366: API does return plain HTML errors * Fix Clippy errors * Improve api response times by doing send_activity asynchronously (#3493) * do send_activity after http response * move to util function * format * fix prometheus * make synchronous federation configurable * cargo fmt * empty * empty --------- Co-authored-by: Dessalines <[email protected]> * Updating `login.rs` with generic `incorrect_login` response. (#3549) * Adding v0.18.1 and v0.18.0 release notes. (#3530) * Update RELEASES.md (#3556) added instruction to find the location of your docker directory (especially useful for those who used ansible since they never had to setup docker manually) * Use async email sender (#3554) * Upgrade all dependencies (#3526) * Upgrade all dependencies * as base64 * Adding phiresky to codeowners. (#3576) * Error enum fixed (#3487) * Create error type enum * Replace magic string slices with LemmyErrorTypes * Remove unused enum * Add rename snake case to error enum * Rename functions * clippy * Fix merge errors * Serialize in PascalCase instead of snake_case * Revert src/lib * Add serialization tests * Update translations * Fix compilation error in test * Fix another compilation error * Add code for generating typescript types * Various fixes to avoid breaking api * impl From<LemmyErrorType> for LemmyError * with_lemmy_type * trigger ci --------- Co-authored-by: SleeplessOne1917 <[email protected]> * Only update site_aggregates for local site (#3516) * Fix #3501 - Fix aggregation counts for elements removed and deleted (#3543) Two bugs were found and fixed: - previously elements removal and deletion were counted as two separate disappearances - removing comments did not affect post aggregations * Use LemmyErrorType also make error_type compulsory * Add missing import for jsonify_plain_text_errors * Fix formatting * Trying to make woodpecker run again --------- Co-authored-by: phiresky <[email protected]> Co-authored-by: Dessalines <[email protected]> Co-authored-by: rosenjcb <[email protected]> Co-authored-by: nixoye <[email protected]> Co-authored-by: dullbananas <[email protected]> Co-authored-by: Nutomic <[email protected]> Co-authored-by: SleeplessOne1917 <[email protected]> Co-authored-by: Sander Saarend <[email protected]> Co-authored-by: Piotr Juszczyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, scheduled tasks write site_aggregates values of the current site into rows for all sites due to a missing WHERE clause. This PR limits it only to the row where site_id = 1 (in other words, the local site).