Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing security.txt to use github security advisories page. #2334

Merged
merged 8 commits into from
Feb 16, 2024

Conversation

dessalines
Copy link
Member

@Nutomic
Copy link
Member

Nutomic commented Jan 19, 2024

Should we just auto-generate a date which is maybe one year in the future from the build time?

@Nothing4You
Copy link

I don't think this should just link to the github page.
Having the github page in there for the project itself is probably a good idea, but there should also be a (probably optional) instance security contact as well.
Especially for cases when instances are running an older version with known security issues fixed in the latest version, there isn't any point in raising this on github, but instead this should provide a contact to the instance owner directly.
Additionally, some things can be configuration related, such as bad caching configuration or other services on the same domain, like pict-rs, which wouldn't be for the lemmy project itself.

@dessalines
Copy link
Member Author

Having the github page in there for the project itself is probably a good idea, but there should also be a (probably optional) instance security contact as well.

@Nothing4You That's another good argument for removing this entirely, and just letting instance runners serve their own security.txt .

@Nutomic Okay I've added a build date to the dockerfile.

@Nothing4You
Copy link

Maybe it could be integrated in lemmy-ansible instead?

@dessalines
Copy link
Member Author

I'd rather not add complication and extra configuring there.

@urda
Copy link

urda commented Jan 20, 2024

A unit test should be included that FAILS when we pass the expire date again.

Dockerfile Outdated Show resolved Hide resolved
@dessalines
Copy link
Member Author

This is ready to go IMO. @SleeplessOne1917 take a look.

@SleeplessOne1917 SleeplessOne1917 enabled auto-merge (squash) February 16, 2024 15:15
@SleeplessOne1917 SleeplessOne1917 merged commit 1ff4acc into main Feb 16, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

security.txt expires date
5 participants