-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
security.txt expires date #2332
Comments
Does that endpoint even make sense in this way? Most admins are probably not aware of it, and dont configure these email addresses. If anything the email should be provided through an env var, and if none is provided then no security.txt is served. The expires field is documented here. I guess we could auto-generate a date one year in the future, but thats completely arbitrary so maybe it should also be supplied via env. To be honest I would rather remove the security.txt entirely and leave it to instance admins to serve their own via nginx. |
Reading the mail address from .env makes sense, because the ones given there do not exist for me either. I would continue to offer the file, because security problems are more likely to be reported in the project via |
The Lemmy footer has a link to the source code which has a way to report security issues. There is also a link to join-lemmy.org which lists additional contact methods. So I dont think the email is necessary, Im not even sure if its working or if anyone ever used it. cc @dessalines |
Line 7 could then also be changed to:
|
* Changing security.txt to use github security advisories page. - Fixes #2332 * Adding an expires date, one year from build date. * Add a year to the build date in code. * Fix dev.dockerfile build date. --------- Co-authored-by: SleeplessOne1917 <[email protected]>
Requirements
Summary
the date would have to be adjusted:
https://github.com/LemmyNet/lemmy-ui/blob/main/src/server/handlers/security-handler.ts#L14
Lemmy Instance Version
0.19.2
Lemmy Instance URL
https://rollenspiel.forum/
The text was updated successfully, but these errors were encountered: