-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(UI): Make max-width wider, and make sidebar narrower on wide screens (#1536) #1590
fix(UI): Make max-width wider, and make sidebar narrower on wide screens (#1536) #1590
Conversation
This is definitely a light touch that my PR. I do think the navbar would look better if it took up the full width of the screen though. |
@SleeplessOne1917 I think the navbar contents should be limited in width, but making that shadow wrapper full-width is probably an improvement: |
* lemmy/main: chore(DX): Add prettier to eslint config for use with editors fix: Remove unnecessary string interpolations
* lemmy/main: fix: Remove unnecessary class fix: Remove unnecessary classes fix: Restore removed classes fix: Remove wrapping li's fix: Remove extraneous classes fix: Move things back to where they were chore: Separate post mod buttons into functions
* lemmy/main: fix vote button alignment Fix feedback on banning an unbanning remove icon (LemmyNet#1618) Indicate valid and invalid fields in signup form (LemmyNet#1450) capitalize button (LemmyNet#1616) Move password reset form to separate route, view (LemmyNet#1390) feat(UI): Reduce base font size (LemmyNet#1591) Fix: missing semantic css classes and html elements (LemmyNet#1583)
This made reading much worse, because the width of posts and comments also increased. A line of text shouldn't be no more than 90 characters long to keep readability, but now we are up at 140 characters. |
@LizardWizardGB I hear you on that. I’ve been thinking about making the text part only as wide as the title part, so the thumb/voting area provides kind of a left margin. |
Excuse me, but what standard are you quoting for that? We ditched monochrome green-screen monitors with limited character widths in the 1970s. This is Reddit, your competitor, pulling off fullscreen mode just fine. Even with Reddit's restrictive comment width inside the posts, they are still achieving about 110 characters max width. Even your own GitHub comment is 128 characters long, and is plenty readable. Let's get rid of tiny, tiny paragraph widths, and get rid of ancient 1970s standards. |
This is a basic typographical truth that is universally understood. |
I think I just proved that highly-popular and battle-tested web software do not follow this imaginary 90-character limit. |
I think the container width isn't the primary factor in making as many posts visible on a single screen as possible.
Before
After