Large screen style #1584
Large screen style #1584
Conversation
SleeplessOne1917
requested review from
dessalines,
alectrocute and
jsit
as code owners
|
Hm it seems like some of these changes are unrelated to screen widening? |
|
I also removed a bit of unnecessary markup. |
| <div className="col-12 col-lg-6 offset-lg-3 mb-4"> | ||
| <h5>{I18NextService.i18n.t("verify_email")}</h5> | ||
| {this.state.verifyRes.state === "loading" && ( | ||
| <h5> | ||
| <Spinner large /> | ||
| </h5> | ||
| )} |
There was a problem hiding this comment.
All this page displays is a title and a loading spinner. @dessalines should we still keep this file?
|
Post Listing images are now "portrait"-oriented, and are no longer top-aligned with the post title: |
|
Kind of throwing a wrench into things here, but I'm not sure this is even desirable in the first place? I don't know that this makes good use of the extra space gained; it will mostly just make things further apart. I could see changing the max-width to something else (in fact it's larger in Bootstrap 5, and I overwrote the value of 
|
|
From the original issue:
There's still empty space; it's now just between the main and the sidebar. I think this is this one user's personal preference and shouldn't necessarily be globally adopted. |
I agree completely. |
|
Any thoughts on how to make it better? I think there's still too much whitespace but also an improvement on what's there currently. |
|
I thought the top aligned listing images looked funny on post listings with more vertical space. I can change it back if you'd prefer. |
|
Here's an example of another way we might address this: #1590 |
src/shared/components/search.tsx
Outdated
| } = this.state; | ||
|
|
||
| const hasCommunities = |
There was a problem hiding this comment.
Doh. I'll put it back.
|
It seems like there's a lot going on here that, while good improvements, don't really have to do with making things wider. Can these be moved to a separate chore PR? |
|
What specifically do you think doesn't belong in this PR? I've gotten rid of everything not related to displaying on larger screen sizes at this point. |
|
Some of this looks a little wonky to me? This sidebar looks too small, and the comments aren't left-aligned with the post content 
I'd kind of like to see #1590 merged in first, then some more fine-tuning done if necessary. I also like how this PR makes some semantic fixes, but they make the diffs harder to read than they need to be for such a large PR. It might be easier if this were broken up into smaller PRs for each page. |
Closes #1536. Here is what the pages look like now:
Home
Community Page
Communities
Create Post
Create Community
Search
Admin Settings
Inbox
Reports
Modlog
Instances
I still have to do settings and profile. Will update the PR with screenshots when done.