Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand video embeds to fullwidth #1437

Merged
merged 7 commits into from
Jun 22, 2023
Merged

Expand video embeds to fullwidth #1437

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9858514
wrap video embeds in the ratio container
cloventt Jun 21, 2023
c16c00d
add a prefix to hint to screenreaders what this iframe is
cloventt Jun 21, 2023
121ed58
Merge branch 'main' into expand-video-embeds-to-fullwidth
cloventt Jun 21, 2023
3fca825
Merge branch 'main' into expand-video-embeds-to-fullwidth
cloventt Jun 21, 2023
5109118
Merge branch 'main' into expand-video-embeds-to-fullwidth
cloventt Jun 21, 2023
924e670
remove embed prefix until a translation can be added
cloventt Jun 22, 2023
090adee
Merge branch 'main' into expand-video-embeds-to-fullwidth
SleeplessOne1917 Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/shared/components/post/metadata-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,14 @@ export class MetadataCard extends Component<
</div>
)}
{this.state.expanded && post.embed_video_url && (
<iframe
className="post-metadata-iframe"
src={post.embed_video_url}
></iframe>
<div className="ratio ratio-16x9">
<iframe
allowFullScreen
className="post-metadata-iframe"
src={post.embed_video_url}
title={post.embed_title}
></iframe>
</div>
)}
</>
);
Expand Down