Expand video embeds to fullwidth #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should correctly size the embedded video iframe to the full available width, which looks better and is compatible with mobile devices. Also add the "allowfullscreen" modifier to the iframe so that the video can be expanded to the browser's fullscreen mode. Also add the post.embed_title as the iframe "title" attribute.
|
TODO: the text |
|
I haven't been able to test this locally as I haven't been able to get a post with an embed to work properly for some reason. |
|
Tested and can confirm it looks great: https://imgur.com/a/ho0nUIh The video can also be made fullscreen. |
| allowFullScreen | ||
| className="post-metadata-iframe" | ||
| src={post.embed_video_url} | ||
| title={"Embedded Video: " + post.embed_title} |
There was a problem hiding this comment.
If you add the "Embedded Video" string, there will have to be a translation made.. Alternatively, you could just make the title post.embed_title.
There was a problem hiding this comment.
Ok, for now I will remove the prefix, but it is probably worth adding in the future as screen readers might find it useful.
SleeplessOne1917
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Bootstrap 5.0
.ratioclass to wrap embedded video iframe so that it is properly handled in a responsive way. Also addallowfullscreenhint andtitleattribute to embedded iframe.Fixes #926