Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): Add aria-label to featured pins #1354

Merged
merged 17 commits into from
Jun 19, 2023
Merged

fix(a11y): Add aria-label to featured pins #1354

Changes from 5 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ec1d372
fix(a11y): Add aria-label to fetaured pins
jsit Jun 17, 2023
b5d6eda
Empty commit to re-trigger Woodpecker job
jsit Jun 17, 2023
f0283ac
Merge branch 'main' into fix/add-aria-label-to-featured-pins
SleeplessOne1917 Jun 17, 2023
982dbe3
Merge branch 'main' into fix/add-aria-label-to-featured-pins
jsit Jun 18, 2023
30e6cdf
Merge branch 'main' into fix/add-aria-label-to-featured-pins
SleeplessOne1917 Jun 18, 2023
7c26491
feat: Move advanced post menu into dropdown
jsit Jun 17, 2023
96a4df2
fix: Remove unused var
jsit Jun 17, 2023
7db7f6c
Empty commit to re-trigger Woodpecker job
jsit Jun 17, 2023
fc1c4f3
fix: Fix some button labels and tippy text
jsit Jun 17, 2023
fb2c9f7
fix(a11y): Add aria-controls for advanced button dropdown
jsit Jun 17, 2023
b4c83b2
fix: Fix vertical alignment and border radius of advanced dropdown me…
jsit Jun 18, 2023
2e98e28
fix: Remove some extra classes on flag/report buttons
jsit Jun 18, 2023
dcf576f
fix: Use btn-sm for advanced menu dropdown buttons
jsit Jun 18, 2023
fbd2b72
fix: Only post title should be inside h5, not the additional metadata…
jsit Jun 17, 2023
3e0ad0d
fix: Fix display inline of post title
jsit Jun 18, 2023
f98dee6
Merge remote-tracking branch 'origin/main' into fix/add-aria-label-to…
jsit Jun 18, 2023
13df4b9
Merge branch 'main' into fix/add-aria-label-to-featured-pins
SleeplessOne1917 Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/shared/components/post/post-listing.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,15 +582,17 @@ export class PostListing extends Component<PostListingProps, PostListingState> {
{post.featured_community && (
<small
className="unselectable pointer ml-2 text-muted font-italic"
data-tippy-content={i18n.t("featured")}
aria-label={i18n.t("featured_in_community")}
data-tippy-content={i18n.t("featured_in_community")}
>
<Icon icon="pin" classes="icon-inline text-primary" />
</small>
)}
{post.featured_local && (
<small
className="unselectable pointer ml-2 text-muted font-italic"
data-tippy-content={i18n.t("featured")}
aria-label={i18n.t("featured_in_local")}
data-tippy-content={i18n.t("featured_in_local")}
>
<Icon icon="pin" classes="icon-inline text-secondary" />
</small>
Expand Down