-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a11y): Add aria-label to featured pins #1354
Merged
SleeplessOne1917
merged 17 commits into
LemmyNet:main
from
jsit:fix/add-aria-label-to-featured-pins
Jun 19, 2023
Merged
fix(a11y): Add aria-label to featured pins #1354
SleeplessOne1917
merged 17 commits into
LemmyNet:main
from
jsit:fix/add-aria-label-to-featured-pins
Jun 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SleeplessOne1917
approved these changes
Jun 17, 2023
auto-merge was automatically disabled
June 18, 2023 14:19
Head branch was pushed to by a user without write access
…-featured-pins * origin/main: fix: Fix display inline of post title fix: Use btn-sm for advanced menu dropdown buttons fix: Remove some extra classes on flag/report buttons fix: Fix vertical alignment and border radius of advanced dropdown menu items fix(a11y): Add aria-controls for advanced button dropdown fix: Fix some button labels and tippy text Empty commit to re-trigger Woodpecker job fix: Remove unused var feat: Move advanced post menu into dropdown fix: Only post title should be inside h5, not the additional metadata icons
K, I got the translation strings updated. Run |
dessalines
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yarn linting will fail until LemmyNet/lemmy-translations#64 is merged