Comment depth #1072
Comment depth #1072
Conversation
|
User that suggested the change here -- thanks for the (very) quick PR! Hoping this gets merged soon. |
| : colorList[0]; | ||
|
|
||
| return this.props.nodes.length > 0 ? ( | ||
| <ul |
There was a problem hiding this comment.
Should this be an ordered list, since it's sorted by some criterion?
There was a problem hiding this comment.
I could make it ordered. Whichever you think would be better for accessibility. However, I don't think children of top level comments get sorted, so that's worth keeping in mind.
There was a problem hiding this comment.
As @fastfinge said, ul makes more sense from a screen reader perspective. With an ol, you'd (depending on settings) get the item number and the number of items on the list: the comment number and the total number of comments at that depth, in that thread. That seems like a lot of extra info to process.
|
The issue with an ordered list is that it would cause screen readers to read out a number before each comment, and that doesn't seem to make much sense. It matters that the comment is at depth 2, not that it's the fifth comment in this thread at depth 2. Perhaps someone else disagrees, but I'm struggling to think of a reason I'd ever want to innumerate the order of comments. It's the depth that matters here. |
|
The colored lines seem overkill now. Would you just make them gray / muted? Example:
|
|
Colors seem fine but I would make them lighter or translucent. |
|
An option to click on them to collapse threads would also be good, but then you'd probably want to make them wider. |
|
@Kommynct That's a separate issue. Please keep things on topic, we're juggling many things right now. |
|
While we're on an accessibility vibe, passing level AA here would be excellent for readability: |
|
We could have colored vs muted nesting indicators as an option in the settings, leaving them on (colored) by default. I think it's a matter of user preference. |
|
Adding new options is pretty complicated, not a great idea for something so minor. |
|
I think colored is better for visibility, and if you like uncolored lines, I can easily whip up a stylus theme that colors them however you like. If they are uncolored I could probably not make them colored with the selectors. I think we should prioritize accessibility over aesthetics. |
|
Either way, colored or uncolored is a small difference, and can be addressed later on |
|
@Junebugging Now that the big HTTP changes are finally merged into main, I can finish this up. |
|
The comments look like this now.
|
|
@dessalines @jsit @nebeker If you don't have any more requested changes, please approve. |
…into comment-depth
Closes #1069. In addition to making comment threads lists to make them easier to use with screen readers, I also made it easier to track of comment depth visually per a user suggestion. This is what a thread looks like now:
