Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depth of threaded comments is not communicated to a screen reader #1069

Closed
fastfinge opened this issue Jun 3, 2023 · 2 comments · Fixed by #1072
Closed

depth of threaded comments is not communicated to a screen reader #1069

fastfinge opened this issue Jun 3, 2023 · 2 comments · Fixed by #1072
Labels
bug Something isn't working

Comments

@fastfinge
Copy link

Issue Summary

It is difficult for screen reader users to tell when a comment is a new top-level comment, or is a reply to another comment.

Steps to Reproduce

  1. Log into Lemmy, and open a page of threaded comments
  2. Run a screen reader (NVDA or Narrator on Windows, voiceover on Mac or IOS)
  3. navigate through the comments, and notice that it's difficult to know when you've descended a level in a thread, or gone back up a level

Technical details

A good solution to this might be putting hidden text before each comment that says "level 1" or "level 2" etc; I think this is how Reddit handles it? An even better solution would be formatting comments as nested lists. This would allow screen reader users to always know where we are in a thread, and use hotkeys to skip up and down the various levels.

@fastfinge fastfinge added the bug Something isn't working label Jun 3, 2023
@SleeplessOne1917
Copy link
Member

@fastfinge The PR for this is up if you want to see if it works any better with screen readers.

@fastfinge
Copy link
Author

Thanks for the quick response! Based on what I can see from the code and comments, it looks good! Unfortunately I can't test directly. I've followed the ansible deploy instructions, and unfortunately this is my first time using ansible to configure anything. I'm afraid I have no idea how to get it to pull from a particular unmerged PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants