-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rate limiting tab #1031
Rate limiting tab #1031
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once that console logs removed, feel free to merge.
{ | ||
key: "settings", | ||
label: i18n.t("settings"), | ||
getNode: this.userSettings, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
Related, can you try and break out the banned users list into its own tab and make it cleaner? hexbear has thousands and it blows up the page. |
@makotech222 I can do that as part of that reorganization in a separate PR. |
@dessalines I just realized I might need to add some translation before I merge. I'm wondering if should take the strings such as "Message rate limit" and use just "Rate Limit" as the label of the top input and use "Member", "Post", etc. as the tab names. Thoughts? |
render() { | ||
return ( | ||
<form onSubmit={linkEvent(this, submitRateLimitForm)}> | ||
<h5>Rate Limit Options</h5> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i18n here too.
Up to you, whichever is easiest. |
K translations are merged now. |
This closes #981. This is what the rate limiting page looks like:
I also took the liberty of refactoring the tabs into a reusable component.
In addition to this, there was a comment I left on the issue that I'm not sure anyone saw:
Considering those changes would be outside the scope of the rate limit tab, I didn't implement them. Thoughts on the proposed change @dessalines @Nutomic?