Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Rate limit settings into its own tab #981

Closed
dessalines opened this issue Apr 15, 2023 · 3 comments · Fixed by #1031
Closed

Separate Rate limit settings into its own tab #981

dessalines opened this issue Apr 15, 2023 · 3 comments · Fixed by #1031
Labels
enhancement New feature or request

Comments

@dessalines
Copy link
Member

Self explanatory.

@dessalines dessalines added the enhancement New feature or request label Apr 15, 2023
@SleeplessOne1917
Copy link
Member

I'm wondering if only rate limiting should be in its own tab, or if it should be split up even more. Currently, the site tab on the admin page takes up a lot of vertical space and has a lot of information: this means users have to scan through a bunch of stuff to find the setting they want and, when they want to save, have to scroll all the way to the bottom of a long page. Compartmentalizing the settings into a few more tabs should make it both easier to find the setting you're looking for and reduce the scroll distance needed to reach the save button.

Here's what I'm thinking for compartmentalizing the Site tab settings into:

Personalization

  • Name
  • Icon
  • Banner
  • Description
  • Theme
  • Sidebar
  • Legal

General

  • Enable Downvotes
  • Enable NSFW
  • Registration Mode
  • Only admins can create communities
  • Require email verification
  • Email admins on receiving new applications
  • Email admins on receiving new reports
  • Private Instance
  • Hide modlog mod names
  • Slur filter regex
  • Languages
  • Max actor name length
  • Captcha enabled

Federation

  • Federation enabled
  • Allowed/blocked instances
  • Federation debug mode
  • Federation worker count

Rate Limiting

All the rate limiting options.

Let me know what you think.

@dessalines
Copy link
Member Author

dessalines commented May 21, 2023

Sorry I missed this. This seems fine to me, although some of the Personalization and General settings could have overlap.

I see a lot of apps have a Look and Feel settings tab, but we really only have theme there, so that one doesn't make sense to add.

How about a Personalization for the most important things you've already listed, and then rename the General to Additional (or More) Settings, to denote these are less important options, but still available, and on their own tab?

@SleeplessOne1917
Copy link
Member

That works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants