Add support for PWA #1005
Add support for PWA #1005
Conversation
| # Cache deps | ||
| COPY package.json yarn.lock ./ | ||
| RUN yarn install --ignore-scripts --prefer-offline --pure-lockfile |
There was a problem hiding this comment.
This and the environment variables are required to make the image processing library work. See lovell/sharp#3663.
There was a problem hiding this comment.
I was getting constants meant for the client on the server. Changing them to functions fixed it.
| @@ -1,49 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
Yaay thanks, I hated this thing.
| "icons" | ||
| ); | ||
|
|
||
| export async function generateManifestBase64(site: Site) { |
There was a problem hiding this comment.
We should probably re-organize some of this into separate files... not necessary for this PR tho.
| display: "standalone", | ||
| id: "/", | ||
| background_color: "#222222", | ||
| theme_color: "#222222", |
There was a problem hiding this comment.
I wonder if theme_color and background_color should be configurable by instance admins?
There was a problem hiding this comment.
mmm.... lets not do it until someone asks for it lol. Plus I think that would require a local site setting in the database, or some image processing... pry overkill.
This reverts commit b19b51c.
This reverts commit 8a92140.
This was originally meant to address #996, however I decided to set up the service worker so that it would work as a PWA properly on multiple platforms.