Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make webmanifest use custom icon, name, and description #996

Closed
SleeplessOne1917 opened this issue May 4, 2023 · 2 comments
Closed

Make webmanifest use custom icon, name, and description #996

SleeplessOne1917 opened this issue May 4, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@SleeplessOne1917
Copy link
Member

Currently, whenever Lemmy is used as a PWA, the default icon, name, and description are always used.
For example, the instance lemmygrad.ml is named "Lemmygrad" and has the following icon:
Lemmygrad icon

Compare this to what the icon for the Lemmygrad PWA looks like on my phone:
PWA_icon

Currently, the site name, icon, and description are set in the admin page and saved in the database. To implement this, I think we'll have to either have instance admins set those things in the site config, or we could generate the manifest dynamically when a page is being fetched.

@SleeplessOne1917 SleeplessOne1917 added the enhancement New feature or request label May 4, 2023
@dessalines
Copy link
Member

The webmanifest currently is just a static file, but it could built on the fly and served from the node server. It could at least get the correct name of the site and at least one size for the icon.

@SleeplessOne1917
Copy link
Member Author

Closing this since the PR was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants