Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LFO drifting #3003

Merged
merged 2 commits into from
Aug 29, 2016
Merged

Fix LFO drifting #3003

merged 2 commits into from
Aug 29, 2016

Conversation

lukas-w
Copy link
Member

@lukas-w lukas-w commented Aug 26, 2016

This fixes #2501, a regression from 44f1d3d. I don't know why the true parameter was added, so I don't know if reverting the change will have any negative side-effects.

@jasp00
Copy link
Member

jasp00 commented Aug 27, 2016

forceStep is true for manual updates. The value is quantized, which is unfortunate for tempo sync. Removing forceStep ends quantization; the tempo sync model could emit a sync signal to improve accuracy, but this is unfeasible for variable time signatures. So I guess forceStep should be removed.

@lukas-w lukas-w changed the title AutomatableModel: Don't force step size aligning in setValue Fix LFO drifting Aug 29, 2016
@zonkmachine
Copy link
Member

👍 Rock hard sync!

@lukas-w
Copy link
Member Author

lukas-w commented Aug 29, 2016

👍

@lukas-w lukas-w merged commit 37d6e9a into master Aug 29, 2016
@lukas-w lukas-w deleted the iss-2501 branch August 29, 2016 17:50
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants