Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with dropped force step. #3024

Closed
zonkmachine opened this issue Sep 7, 2016 · 3 comments
Closed

Issues with dropped force step. #3024

zonkmachine opened this issue Sep 7, 2016 · 3 comments
Labels
Milestone

Comments

@zonkmachine
Copy link
Member

zonkmachine commented Sep 7, 2016

Since #3003 / 02eee8e
@lukas-w @jasp00

  1. Some floats now needs to be rounded off in presentation. Click and drag Vol/Pan knobs and see the floats in all their glory. Used to be rounded to one decimal precision.
  2. The integers values that use float models?

fishynumbers

@zonkmachine zonkmachine added the bug label Sep 7, 2016
@zonkmachine zonkmachine changed the title Issue with dropped force step. Issues with dropped force step. Sep 7, 2016
@jasp00
Copy link
Member

jasp00 commented Sep 7, 2016

In AutomatableModel, m_hasStrictStepSize should be dropped, and m_step should be used as a restriction from the model, i.e., set m_step to 0 in many float models. m_step is currently being used as a restriction from the view; this rounding to one decimal should be in the view.

@smithjessk
Copy link

smithjessk commented Oct 22, 2016

If #3075 is a good solution for the knobs, I would be happy to extend it to other controls.

@BaraMGB
Copy link
Contributor

BaraMGB commented Oct 22, 2016

A better solution would be to add a new function to Knobs and fader which gives the value truncated. Intern the model uses the untruncated value for sample exact calculations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants