Use fltk-config to avoid static library #2754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Builds fixed. |
|
|
||
| SET(FLTK_FILTERED_LDFLAGS ${FLTK_LIBRARIES}) | ||
| FIND_PROGRAM(FLTK_CONFIG fltk-config) | ||
| IF(FLTK_CONFIG AND NOT (LMMS_BUILD_APPLE OR LMMS_BUILD_WIN32)) |
There was a problem hiding this comment.
@jasp00 Thanks!
Can we get a small comment in the file about why this is required.... e.g. Remove unnecessary X11 linking or whatever the original issue description/pr description was?
I had the same issue and it looks like #2754 fixes this. |
|
I've reviewed this and it looks fine, but first I think we should put a comment in the source code about what the purpose of this is. 👍 Once that's done, please feel free to merge. |
|
Commented. |
|
👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the problem @midi-pascal has in #2749.