-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove useless dependencies #2749
Conversation
# vocoder_1337 does not use fftw3f | ||
IF(NOT ("${_plugin}" STREQUAL "vocoder_1337")) | ||
TARGET_LINK_LIBRARIES("${_plugin}" -lfftw3f) | ||
ENDIF() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! We can merge this, but it also needs to make it to https://github.com/swh/ladspa. Many projects use Steve's upstream swh
LADSPA packages and Steve's pretty good about merging in these types of PRs.
Edit: Upstream doesn't use vocoder yet and it doesn't utilize CMakeLists.txt
, so this is ours only. 👍
Builds are fixed. |
@jasp00 sure if you think you can help. I ran out of time working on it, but the build/xml file I was working on is available here if you think it helps: https://github.com/tresf/ladspa/blob/vocoder/vocoder_1337.xml P.S. Sorry for delay on merging these. The work you're doing is great and we desperately need the help, we're just very behind on things currently. Off-topic to this particular PR but the Anyway, we'll get to your PRs ASAP. Thanks again. 👍 |
👍 |
@jasp00 @tresf The commit 60740fb breaks the build on my Ubuntu 14.04 x64 with this error: |
Your build is using the static library |
@jasp00 |
@jasp00 Your fix solves the problem 👍 |
Some objects depend on a library without using any of its symbols; this generates a useless dependency in packaged software.
RemoteZynAddSubFx
depended on libdl, libX11 and libXext. The vocoder LADSPA plugin depended on libfftw3f.