Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.2.0-RC1] export (.wav and .ogg) stops after 3:54 on Win7Pro #3105

Closed
hedwig2013 opened this issue Nov 6, 2016 · 16 comments
Closed

[1.2.0-RC1] export (.wav and .ogg) stops after 3:54 on Win7Pro #3105

hedwig2013 opened this issue Nov 6, 2016 · 16 comments
Milestone

Comments

@hedwig2013
Copy link

Each time i'm trying to export a project it stops at 3:54. The Project is over 9 minutes long. A short "sound shock" can be heard in the moment lmms stops the export.

@tresf tresf added this to the 1.2.0 milestone Nov 6, 2016
@DeRobyJ
Copy link
Contributor

DeRobyJ commented Nov 7, 2016

Hi, I'm on Win7Pro on a more recent build, and I've exported longer projects, so I think it's been fixed.

But, to be sure, could you upload this project for us to test, or check if it always happens with any project?

@hedwig2013
Copy link
Author

Hi, here is a screenshot with export configurations. I can't attach the original file here cause it is copyrighted material. The file has 17 voices and uses sf2 player instrument only. The SoundFont is the GeneralUser GS 1.47 Soundfont. https://lmms.io/documentation/Useful_resources http://www.schristiancollins.com/generaluser.php I'm using automation tracks for pitch and volume. The play time is about 9:25. A second screenshot visualizes the song's structure. The bass instruments are configured with a BassBooster and the Calf Reverb LADSPA is used in the FX-Mixer.

The lmms installation is unchanged. The preferences are unchanged with the exception that i configured the default soundfont as GeneralUser GS 1.47 file.

I hope this will help you to reproduce the bug.

Thanks!

capture

capture1

@tresf
Copy link
Member

tresf commented Nov 7, 2016

I can't attach the original file here cause it is copyrighted material.

If you can exchange it privately with a tester (such as @DeRobyJ) to confirm that the latest fixes it, that would help. If not, we would need a project file which reproduces the crash but does not violate any copyrights.

@hedwig2013
Copy link
Author

Done via mail

@DeRobyJ
Copy link
Contributor

DeRobyJ commented Nov 11, 2016

gmail put the mail in spam, I just read it >_>
I can reproduce. Each time I export, it will stop at a certain point, even on a more recent version.

And the problem is the time signature.
The first point that stops the export is around 1:20 rather than 3:54, and that's exactly the place where time signature changes from 4/4 to I believe 5/4.
There, export fails, and if it doesn't fail there, it will sooner or later.

Can you please create a copy of your project and remove global automation of the time signature?
The song should be exported fine.

Then, I tested the problem on a new project, and it seems there's no problem. So there's something else that makes time signature crash the export process.

@zonkmachine
Copy link
Member

#2030 ?

@liushuyu
Copy link
Member

liushuyu commented Nov 11, 2016 via email

@DeRobyJ
Copy link
Contributor

DeRobyJ commented Nov 12, 2016

Kinda, but I can't reproduce on a new project

@hedwig2013
Copy link
Author

hedwig2013 commented Nov 13, 2016

Sorry, but now it does not simply stops. Now it hangs or crashes. Even if I remove all global automations of any type. The behaviour is the same for "export" and "export tracks". I used the same file i send you previously. While "export tracks" it can export some tracks.

2016-11-13 16_59_06-yes - homeworld
2016-11-13 17_08_10 lmms crash
2016-11-13 16_57_50-rendering_ 100

@DeRobyJ
Copy link
Contributor

DeRobyJ commented Nov 13, 2016

That could be because of how unstable was that build, there's no problem in my version

@hedwig2013
Copy link
Author

Okay. So I will retest with the next RC. Thank you for your support so far.

@DeRobyJ
Copy link
Contributor

DeRobyJ commented Nov 14, 2016

Thank you for sharing the issue :)

@softrabbit
Copy link
Member

https://github.com/LMMS/lmms/blob/master/src/core/ProjectRenderer.cpp#L183

The export loop condition contains Song::isExportDone(),which checks for the done-ness by doing math that will be wrong at some point as soon as the song contains more than one time signature, see https://github.com/LMMS/lmms/blob/master/src/core/Song.cpp#L431. It multiplies the song length in bars with the length of a bar to get a value in ticks, which obviously breaks when the time signature changes.

Maybe checking the current position against exportEndpoints.second would be wiser?

@Umcaruje
Copy link
Member

@hedwig2013 can you retest with the RC2 please?

Umcaruje pushed a commit that referenced this issue May 29, 2017
* Change loop condition in ProjectRenderer::run()

* Remove Song::isExportDone()
@Umcaruje
Copy link
Member

The op hasn't replied in more than a month and #3576 should fix this. It will be available in RC3. If this issue still exists in RC3, @hedwig2013 let us know so we reopen.

@hedwig2013
Copy link
Author

Sorry for my late response. The bug is fixed. Everything is working fine.

PhysSong added a commit to PhysSong/lmms that referenced this issue Jul 8, 2017
…3576)

* Change loop condition in ProjectRenderer::run()

* Remove Song::isExportDone()
PhysSong added a commit to PhysSong/lmms that referenced this issue Jul 8, 2017
…3576)

* Change loop condition in ProjectRenderer::run()

* Remove Song::isExportDone()
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this issue Jun 28, 2022
…3576)

* Change loop condition in ProjectRenderer::run()

* Remove Song::isExportDone()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants