Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KRPC-18 Add K2 and IR code generation plugins, preserve KSP for K1 #105

Merged
merged 17 commits into from
Aug 15, 2024
Merged

KRPC-18 Add K2 and IR code generation plugins, preserve KSP for K1 #105

merged 17 commits into from
Aug 15, 2024

Conversation

Mr3zee
Copy link
Collaborator

@Mr3zee Mr3zee commented Jun 19, 2024 •
edited
Loading

Adds support for K2 code generation. Uses K2 compiler plugin instead of KSP.
Backend Compiler Plugin now generates most of the code, FIR plugin for K2 and KSP for K1 only generate minimal declarations needed for Serialization and metadata generation on the frontend.

This is a meta-PR that accumulated many other PRs, see corresponding commits and PR descriptions.

@Mr3zee Mr3zee self-assigned this Jun 19, 2024
@Mr3zee Mr3zee force-pushed the compiler-plugin branch 3 times, most recently from ad99de0 to 28bf0b9 Compare June 24, 2024 17:58
@Mr3zee Mr3zee force-pushed the compiler-plugin branch from 28bf0b9 to 391d9ae Compare June 28, 2024 12:53
@efemoney
Copy link

efemoney commented Jul 9, 2024

Curious, is there more information on this change? Motivation, effect, etc

@Mr3zee
Copy link
Collaborator Author

Mr3zee commented Jul 15, 2024

@efemoney basically these reasons:

  • KSP Gradle plugin needs to be added explicitly by the user, that's a friction in UX
  • KSP does not support Gradle configuration caches
  • KSP exposes generated code, which we often don't want to do to keep the sources clean
  • KSP does not allow for existing code modifications, so we need a compiler plugin anyway
  • K2 frontend compiler plugins will allow for IDE integration for generated declarations in future, so we might make use of it too

@efemoney
Copy link

Makes sense! Thanks

@Mr3zee Mr3zee force-pushed the compiler-plugin branch from 391d9ae to facd3eb Compare July 17, 2024 08:50
@sureshg sureshg mentioned this pull request Jul 17, 2024
Closed
@Mr3zee Mr3zee changed the title Replace KSP with Compiler Plugins Added K2 and IR code generation plugins, preserve KSP for K1 Aug 13, 2024
@Mr3zee Mr3zee changed the title Added K2 and IR code generation plugins, preserve KSP for K1 Add K2 and IR code generation plugins, preserve KSP for K1 Aug 13, 2024
Mr3zee added 12 commits August 13, 2024 19:18
@Mr3zee
Introduce common IR backend plugin (1/2) (#44)
82a6cba 
* [IR] preparation for IR plugin

* Introduce common IR backend plugin (2/2) (#45)

* [IR] replace part of KSP with IR plugin

* review comments
@Mr3zee
Update IR plugin to the latest library version
5064c76
@Mr3zee
Replaced compiler-specific modules with version-specific source sets (#…
54dee83 
…84)
@Mr3zee
K2 plugin (#116)
e0ce7b8 
* Introduce K2 plugin

* Update IR backend

* Update to 2.0

* Fix for KT-70132
@Mr3zee
yarn.lock (#148)
56d55b6
@Mr3zee
Update docs for K2 (#153)
b2fbd81
@Mr3zee
Restructure compiler-plugin module into: backend, k2, common and cli (#…
877e029 
…149)
@Mr3zee
Fix CSM resources load for all Kotlin versions (#152)
10faf14
@Mr3zee
Simplified gradle configurations (#154)
b7762c0
@Mr3zee
Update project for K1 usage (#155)
b4c29a7
@Mr3zee
Update the project to run tests without the useK2Plugin property (#156)
4c1bc5b
@Mr3zee
Compiler plugin tests (#157)
84a1a86
@Mr3zee Mr3zee force-pushed the compiler-plugin branch 2 times, most recently from 99261fc to c322248 Compare August 14, 2024 10:46
@Mr3zee Mr3zee requested a review from e5l August 14, 2024 10:48
@Mr3zee Mr3zee marked this pull request as ready for review August 14, 2024 10:49
@Mr3zee Mr3zee linked an issue Aug 14, 2024 that may be closed by this pull request
Kotlin 2.0.0 support :) #90
Closed
@Mr3zee
Project configuration and compilation fixes:
c3cd582 
- apiDump
- Fix compilation for older Kotlin compiler plugins
- Fix configs for tests and yarn.lock
- Disable KSP plugin for local tests
- Added 100000 requests test (checks for possible memory leaks)
e5l
e5l approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Good job! It also would be great to mention YT ticket in the header and update description

@Mr3zee
Copy link
Collaborator Author

Mr3zee commented Aug 14, 2024

@e5l thank you! Yes, forgot to do it, well do soon

@Mr3zee Mr3zee changed the title Add K2 and IR code generation plugins, preserve KSP for K1 KRPC-18 Add K2 and IR code generation plugins, preserve KSP for K1 Aug 15, 2024
@Mr3zee Mr3zee merged commit d1c833f into main Aug 15, 2024
5 checks passed
@Mr3zee Mr3zee deleted the compiler-plugin branch August 15, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e5l e5l e5l approved these changes

Assignees

@Mr3zee Mr3zee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kotlin 2.0.0 support :)
3 participants
@Mr3zee @efemoney @e5l