K2 plugin #116
Merged
K2 plugin #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr3zee
force-pushed
the
k2-plugin
branch
3 times, most recently
from
e6f5291 to
6d58130
Compare
|
No tests will be executed for this review for two reasons:
I tested the PR locally, and it works for existing tests, I just don't want to have an intermediate state of CI configs just for this review. |
Mr3zee
commented
Aug 3, 2024
Comment on lines
-65
to
+71
| tasks.withType<ProcessResources>().configureEach { | ||
| duplicatesStrategy = DuplicatesStrategy.EXCLUDE | ||
|
|
||
| from(versionNames.map { vsResources.resolve(it) }) | ||
| include { it.file.parentInAllowList(versionNames) } | ||
| } | ||
| // todo duplicate (or to many resources are copied, should update the algo) | ||
| // tasks.withType<ProcessResources>().configureEach { | ||
| // duplicatesStrategy = DuplicatesStrategy.EXCLUDE | ||
| // | ||
| // from(versionNames.map { vsResources.resolve(it) }) | ||
| // include { it.file.parentInAllowList(versionNames) } | ||
| // } |
There was a problem hiding this comment.
I will fix it in a separate PR
e5l
approved these changes
Aug 5, 2024
compiler-plugin/compiler-plugin-k2/src/main/core/kotlinx/rpc/codegen/FirRPCServiceGenerator.kt
Outdated
Show resolved
Hide resolved
|
@e5l do you have someone specific in mind? UPD: nevermind, I see |
demiurg906
reviewed
Aug 5, 2024
compiler-plugin/compiler-plugin-k2/src/main/core/kotlinx/rpc/codegen/FirRPCServiceGenerator.kt
Outdated
Show resolved
Hide resolved
| @Suppress("unused") | ||
| private val logger: MessageCollector, | ||
| ) : FirDeclarationGenerationExtension(session) { | ||
| private val serializationExtension = SerializationFirResolveExtension(session) |
There was a problem hiding this comment.
The trick with your own generator from serialization plugin is nice
Like it
compiler-plugin/compiler-plugin-k2/src/main/core/kotlinx/rpc/codegen/FirRPCServiceGenerator.kt
Outdated
Show resolved
Hide resolved
compiler-plugin/compiler-plugin-k2/src/main/core/kotlinx/rpc/codegen/FirRPCServiceGenerator.kt
Outdated
Show resolved
Hide resolved
|
@demiurg906 thanks for the review! Yes, you're right, we talked about checkers, they will be shipped separately |
Mr3zee
added a commit
that referenced
this pull request
Aug 6, 2024
* Introduce K2 plugin * Update IR backend * Update to 2.0 * Fix for KT-70132
Mr3zee
added a commit
that referenced
this pull request
Aug 13, 2024
* Introduce K2 plugin * Update IR backend * Update to 2.0 * Fix for KT-70132
Mr3zee
added a commit
that referenced
this pull request
Aug 15, 2024
* Introduce K2 plugin * Update IR backend * Update to 2.0 * Fix for KT-70132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
K2 Compiler plugin
Problem Description
We are migrating from KSP code generation to compiler plugins.
Solution
This is part 2 of 3 in the migration process, which presents the K2 frontend plugin.
K2 plugin overview:
Also PR contains addition of an
compiler-plugin-commonmodule for shared declarations between backend and frontend(s).PR contains upgrade to Kotlin 2.0 as it required to make K2 plugin work. Project language level is set to 1.7 by default, so K2 will not be used by default. For it to be used in tests, use dedicated
kotlinx.rpc.useK2Plugin=truein rootgradle.properties