Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix a typo causes useless calculation #17

Merged
merged 1 commit into from
Jul 24, 2023
Merged

fix: fix a typo causes useless calculation #17

merged 1 commit into from
Jul 24, 2023

Conversation

rodman10
Copy link
Contributor

Fix typo in job.lua :)
See #16

@CLAassistant
Copy link

CLAassistant commented Jul 24, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ADD-SP ADD-SP linked an issue Jul 24, 2023 that may be closed by this pull request
Confusion when reading code #16
Closed
@ADD-SP ADD-SP self-assigned this Jul 24, 2023
@ADD-SP ADD-SP added the bug Something isn't working label Jul 24, 2023
ADD-SP
ADD-SP approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rodman10 !

@ADD-SP ADD-SP changed the title fix(job.lua): fix typo. fix: fix a typo causes useless calculation Jul 24, 2023
@ADD-SP ADD-SP merged commit 3f32dfe into Kong:main Jul 24, 2023
@ADD-SP ADD-SP mentioned this pull request Jan 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADD-SP ADD-SP ADD-SP approved these changes

Assignees

@ADD-SP ADD-SP

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusion when reading code
3 participants
@rodman10 @CLAassistant @ADD-SP