Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusion when reading code #16

Closed
rodman10 opened this issue Jul 23, 2023 · 1 comment · Fixed by #17
Closed

Confusion when reading code #16

rodman10 opened this issue Jul 23, 2023 · 1 comment · Fixed by #17
Labels
bug Something isn't working

Comments

@rodman10
Copy link
Contributor

rodman10 commented Jul 23, 2023 •
edited
Loading

When I read the source code, I was confused by the following code
https://github.com/Kong/lua-resty-timer-ng/blob/main/lib/resty/timerng/job.lua#L254C17-L254C27
whether the immediate in the above code should be replaced by _immediate ? Is it a typo? Thanks for reply :) !
@ADD-SP
Copy link
Collaborator

ADD-SP commented Jul 24, 2023

Yes, it is a typo. Luckily, it doesn't cause any bugs, just useless calculations. Thank you @rodman10 .

PR welcome!

@ADD-SP ADD-SP added the bug Something isn't working label Jul 24, 2023
@rodman10 rodman10 mentioned this issue Jul 24, 2023
Merged
@ADD-SP ADD-SP linked a pull request Jul 24, 2023 that will close this issue
fix: fix a typo causes useless calculation #17
Merged
ADD-SP pushed a commit that referenced this issue Jul 24, 2023
@rodman10
fix: fix a typo causes useless calculation (#17)
3f32dfe 
Thanks @rodman10 .
Issue: #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix a typo causes useless calculation rodman10/lua-resty-timer-ng
2 participants
@rodman10 @ADD-SP