Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled backup allowed #537

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Disabled backup allowed #537

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e6133b
Disabled backup allowed
prateek-singh-3212 Aug 20, 2024
5135123
Marked allow backup to false
prateek-singh-3212 Aug 21, 2024
873a812
Merge branch 'development' into CM-2161-Remove-app-Debug-and-Backup-u…
prateek-kommunicate Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@

<application
android:name="kommunicate.io.sample.KommunicateApplication"
android:allowBackup="true"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prateek-kommunicate Default value looks true, removing this should not help. Please make it false

https://developer.android.com/guide/topics/manifest/application-element#allowbackup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see. I just checked that out more. Above Android 12 allowBackup false wont stop the device to device data transfers. So for that we have to add the data_extraction_rules which disables all the device to device transfers and cloud backups.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, as discussed please test it with the Sample SDK with reverse configurations.

android:icon="@mipmap/ic_launcher_without_shape"
android:label="@string/app_name"
android:supportsRtl="true"
Expand Down
1 change: 0 additions & 1 deletion kommunicate/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@


<application
android:allowBackup="true"
android:label="@string/app_name"
android:supportsRtl="true">

Expand Down
1 change: 0 additions & 1 deletion kommunicateui/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
</queries>

<application
android:allowBackup="true"
android:label="@string/app_name"
android:supportsRtl="true">
<provider
Expand Down
8 changes: 8 additions & 0 deletions local.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
## This file must *NOT* be checked into Version Control Systems,
# as it contains information specific to your local configuration.
#
# Location of the SDK. This is only used by Gradle.
# For customization when using a Version Control System, please read the
# header note.
#Fri Aug 16 18:38:45 IST 2024
sdk.dir=C\:\\Users\\91966\\AppData\\Local\\Android\\Sdk